Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PDL::Slatec::polyfit() weight dimension mismatch issue #59

Merged
merged 3 commits into from Mar 5, 2015

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Mar 5, 2015

See https://sourceforge.net/p/pdl/bugs/368/, #48
for more information.

@zmughal zmughal added the pr:wip label Mar 5, 2015
@zmughal
Copy link
Member Author

zmughal commented Mar 5, 2015

The results of d245a61 should show that the TODO tests in t/issue-sf-368.t are failing and if all goes well, 9320157 should show the tests pass now.

Then I will remove the TODO status from the tests.

This reproduces the case where sending a weight vector ($w) that does
not match the length of the data to fit ($x, $y) causes garbage to be
sent to the underlying Slatec polfit() function.

See <https://sourceforge.net/p/pdl/bugs/368/>, <#48>
for more information.
@zmughal zmughal merged commit 0e01363 into master Mar 5, 2015
@wchristian wchristian deleted the slatec-polyfit-weight-len branch March 6, 2015 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant