[Truffle] Including RegexpOptions in RubyRegexp #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more correct options from the options method.
| return getContext().getCoreLibrary().getNilObject(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we factor this out into a helper method that takes two ByteList objects?
chrisseaton
added a commit
that referenced
this pull request
Feb 28, 2015
[Truffle] Including RegexpOptions in RubyRegexp
|
Thanks! In the future, if not too much of a hassle, please split different method implementations into different commits. We've had to revert method implementations in the past because of failing benchmarks and what not. It's just much easier to cope with that if the commits are more scoped in nature. I usually use "git add -p" to do it if I've been working in a file for a while. But, if it gets to hairy, a holistic commit like this is fine -- we're pragmatic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be able to return more correct options from the options method.