Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
test: fix pummel/test-net-connect-econnrefused
Browse files Browse the repository at this point in the history
The test relied on a peculiarity of process.nextTick() that was changed in
commit 4e5fe2d. Before that commit, each nextTick callback corresponded with
the event loop moving forward one tick. That's no longer the case.
  • Loading branch information
bnoordhuis committed Aug 8, 2012
1 parent 6770555 commit 6b58800
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions test/pummel/test-net-connect-econnrefused.js
Expand Up @@ -27,7 +27,7 @@ var net = require('net');

var ROUNDS = 5;
var ATTEMPTS_PER_ROUND = 200;
var rounds = 0;
var rounds = 1;
var reqs = 0;

pummel();
Expand All @@ -39,21 +39,20 @@ function pummel() {
net.createConnection(common.PORT).on('error', function(err) {
assert.equal(err.code, 'ECONNREFUSED');
if (--pending > 0) return;
if (++rounds < ROUNDS) return pummel();
check();
if (rounds == ROUNDS) return check();
rounds++;
pummel();
});
reqs++;
}
}

function check() {
process.nextTick(function() {
process.nextTick(function() {
assert.equal(process._getActiveRequests().length, 0);
assert.equal(process._getActiveHandles().length, 0);
check_called = true;
});
});
setTimeout(function() {
assert.equal(process._getActiveRequests().length, 0);
assert.equal(process._getActiveHandles().length, 1); // the timer
check_called = true;
}, 0);
}
var check_called = false;

Expand Down

0 comments on commit 6b58800

Please sign in to comment.