Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: d01a900078ab
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 8bcd0a4c4a8e
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 5, 2015

  1. http: fix performance regression for GET requests 

    A significant performance regressions has been introduced in 1fddc1f for
GET requests which send data through response.end(). The number of
requests per second dropped to somewhere around 6% of their previous
level.

The fix consists of removing a part of the lines added by 1fddc1f,
lines which were supposed to affect only HEAD requests, but interfered
with GET requests instead.

The lines removed would not have affected the behaviour in the case of
a HEAD request as this._hasBody would always be false. Therefore, they
were not required to fix the issue reported in #8361.

Fixes #8940.

PR: #9026
PR-URL: #9026
Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    @CGavrila
    CGavrila authored and Julien Gilli committed Mar 5, 2015
    Copy the full SHA
    8bcd0a4 View commit details
    Browse the repository at this point in the history