opal · Feb 28, 2015 · Feb 28, 2015
Showing with 16 additions and 1 deletion.

+2 −0 CHANGELOG.md

+3 −1 opal/corelib/module.rb

+10 −0 spec/filters/bugs/module.rb

+1 −0 spec/rubyspecs
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@
 
 *   `Array#product` implementation fully compliant with rubyspec
 
+*   `Module#const_get` accepts a scoped constant name
+
 ## 0.7.1 2015-02-14
 
 *   CLI options `-d` and `-v` now set respectively `$DEBUG` and `$VERBOSE`

diff --git a/opal/corelib/module.rb b/opal/corelib/module.rb
@@ -208,8 +208,10 @@ def const_defined?(name, inherit = true)
   end
 
   def const_get(name, inherit = true)
+    if name['::'] && name != '::'
+      return name.split('::').inject(self){|o, c| o.const_get(c)}
+    end
     raise NameError, "wrong constant name #{name}" unless name =~ /^[A-Z]\w*$/
-
     %x{
       var scopes = [self.$$scope];
 

diff --git a/spec/filters/bugs/module.rb b/spec/filters/bugs/module.rb
@@ -11,6 +11,16 @@
 
   fails "Module#const_defined? should not search parent scopes of classes and modules if inherit is false"
   fails "Module#const_get should not search parent scopes of classes and modules if inherit is false"
+  fails "Module#const_get raises a NameError with the not found constant symbol"
+  fails "Module#const_get calls #to_str to convert the given name to a String"
+  fails "Module#const_get raises a TypeError if conversion to a String by calling #to_str fails"
+  fails "Module#const_get does not search the singleton class of a Class or Module"
+  fails "Module#const_get raises a NameError if the constant is defined in the receiver's supperclass and the inherit flag is false"
+  fails "Module#const_get accepts a toplevel scope qualifier"
+  fails "Module#const_get raises a NameError if a Symbol is a scoped constant name"
+  fails "Module#const_get with dynamically assigned constants searches a module included in the immediate class before the superclass"
+  fails "Module#const_get with dynamically assigned constants searches a module included in the superclass"
+  fails "Module#const_get with dynamically assigned constants searches the superclass chain"
 
   fails "Module#class_variable_set sets the value of a class variable with the given name defined in an included module"
   fails "Module#class_variable_get returns the value of a class variable with the given name defined in an included module"

diff --git a/spec/rubyspecs b/spec/rubyspecs
@@ -72,6 +72,7 @@ corelib/core/matchdata/values_at_spec
 corelib/core/module/class_variable_get_spec
 corelib/core/module/class_variable_set_spec
 corelib/core/module/module_function_spec
+corelib/core/module/const_get_spec
 
 corelib/core/range/begin_spec
 corelib/core/range/case_compare_spec