[Truffle] Adding Implementations for Symbol#slice specs. #2645

bjfish · 2015-03-04T14:53:49Z

String#num_bytes was added as a regular method because adding it as an attr_reader did not appear to work.

chrisseaton · 2015-03-04T14:56:24Z

truffle/src/main/ruby/core/rubinius/bootstrap/string.rb

@@ -76,4 +76,8 @@ def find_character(offset)
    raise PrimitiveFailure, "String#find_character primitive failed"
  end

+  def num_bytes
+    @num_bytes


The reason you couldn't use this with an attribute reader is that we replace reads of @num_bytes in our translator with a method that reads it from the actual string object - see

jruby/truffle/src/main/java/org/jruby/truffle/translator/BodyTranslator.java

Lines 1568 to 1573 in 4eb0045

if (nameWithoutSigil.equals("@num_bytes")) {

return new RubyCallNode(context, sourceSection,

"bytesize",

new SelfNode(context, sourceSection),

null,

false);

[Truffle] Adding Implementations for Symbol#slice specs.

bjfish added 4 commits March 4, 2015 08:25

[Truffle] Implemented MatchData#size.

0a4c00f

[Truffle] Adding String#num_bytes.

cdd63dc

[Truffle] Fixing error in Symbol#[].

5920f7f

Adding Symbol#match in ruby.

ad6b8f3

chrisseaton reviewed Mar 4, 2015
View reviewed changes

chrisseaton added a commit that referenced this pull request Mar 4, 2015

Merge pull request #2645 from bjfish/truffle_symbole_slice

ee8b11a

[Truffle] Adding Implementations for Symbol#slice specs.

chrisseaton merged commit ee8b11a into jruby:master Mar 4, 2015

chrisseaton modified the milestone: truffle-dev May 4, 2015

enebo added this to the Non-Release milestone Dec 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

[Truffle] Adding Implementations for Symbol#slice specs. #2645

[Truffle] Adding Implementations for Symbol#slice specs. #2645

bjfish commented Mar 4, 2015

chrisseaton Mar 4, 2015

	if (nameWithoutSigil.equals("@num_bytes")) {
	return new RubyCallNode(context, sourceSection,
	"bytesize",
	new SelfNode(context, sourceSection),
	null,
	false);

[Truffle] Adding Implementations for Symbol#slice specs. #2645

[Truffle] Adding Implementations for Symbol#slice specs. #2645

Conversation

bjfish commented Mar 4, 2015

chrisseaton Mar 4, 2015

Choose a reason for hiding this comment