[Truffle] Adding Implementations for Symbol#slice specs. #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,4 +76,8 @@ def find_character(offset) | |||
| raise PrimitiveFailure, "String#find_character primitive failed" | |||
| end | |||
|
|
|||
| def num_bytes | |||
| @num_bytes | |||
There was a problem hiding this comment.
The reason you couldn't use this with an attribute reader is that we replace reads of @num_bytes in our translator with a method that reads it from the actual string object - see
jruby/truffle/src/main/java/org/jruby/truffle/translator/BodyTranslator.java
Lines 1568 to 1573 in 4eb0045
chrisseaton
added a commit
that referenced
this pull request
Mar 4, 2015
[Truffle] Adding Implementations for Symbol#slice specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#num_bytes was added as a regular method because adding it as an attr_reader did not appear to work.