[Truffle] - String#downcase! raises a RuntimeError when self is frozen

jruby · Mar 4, 2015 · ee6c4a9 · ee6c4a9 · chrisseaton · Mar 4, 2015
1 parent d996099
commit ee6c4a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/spec/truffle/tags/core/string/downcase_tags.txt b/spec/truffle/tags/core/string/downcase_tags.txt
@@ -1,4 +1,3 @@
 fails:String#downcase is locale insensitive (only replaces A-Z)
 fails:String#downcase taints result when self is tainted
 fails:String#downcase returns a subclass instance for subclasses
-fails:String#downcase! raises a RuntimeError when self is frozen
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java
@@ -778,6 +778,8 @@ public RubyBasicObject downcase(RubyString string) {
 
             if (newByteList.equal(string.getBytes())) {
                 return getContext().getCoreLibrary().getNilObject();
+            } else if (string.isFrozen()) {
+                throw new RaiseException(getContext().getCoreLibrary().runtimeError("can't modify frozen string", this));
             } else {
                 string.set(newByteList);
                 return string;