Produce a warning on private attribute accessors #2637
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People seem to do that a lot after Sandi's book and not many of them realize it actually produces a warning in CRuby. Tried getting TestModule#test_attr out of the CRuby excluded failures, because it was the only existing test I saw hinting of the behaviour, however it also test that attribute names can't be a invalid identifiers, which seems to go fine in JRuby.
enebo
added a commit
that referenced
this pull request
Mar 3, 2015
Produce a warning on private attribute accessors
kares
pushed a commit
to kares/jruby
that referenced
this pull request
Jun 4, 2015
I'm sorry for the back and forth on this one. I introduced it back in jruby#2637, but CRuby have recently removed the warning in https://bugs.ruby-lang.org/issues/10967.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People seem to do that a lot after Sandi's book and not many of them
realize it actually produces a warning in CRuby.
Tried getting TestModule#test_attr out of the CRuby excluded failures,
because it was the only existing test I saw hinting of the behaviour,
however it also test that attribute names can't be a invalid
identifiers, which seems to go fine in JRuby.