Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the hash-uri container as a pairtree node, exclude it from Resource... #565

Merged
merged 1 commit into from Oct 22, 2014

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Oct 20, 2014

...#getChildren() requests, and ensure clients can't create 'deep' hash uri resources from a request body

https://www.pivotaltracker.com/story/show/81034970

@@ -151,7 +151,9 @@ public String getPath() {
@Override
public Iterator<FedoraResource> apply(final Node input) {
try {
if (input.isNodeType(FEDORA_PAIRTREE)) {
if (input.getName().equals("#")) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be clearer/more-appropriate to have the logic of "input.getName().equals("#")" in the predicate: FedoraResourceImpl.nastyChildren ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

…rce#getChildren() requests, and ensure clients can't create 'deep' hash uri resources from a request body
awoods pushed a commit that referenced this pull request Oct 22, 2014
Mark the hash-uri container as a pairtree node, exclude it from Resource...
@awoods awoods merged commit 2031155 into master Oct 22, 2014
@awoods awoods deleted the hash-uris branch October 22, 2014 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants