Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assgn badflag propagation #2

Closed
wants to merge 11 commits into from
Closed

Assgn badflag propagation #2

wants to merge 11 commits into from

Conversation

hainest
Copy link

@hainest hainest commented Jul 20, 2012

Add propagation of badflag with .= (Ops::assgn) for sf.net bug 3543056.

I tried to make the documentation as explicit as I could that badflags are not automatically propagated to the parent of a subpiddle, and pointed to the relevant sections of PDL::Bad docs.

Many thanks.

Tim

Tim Haines added 11 commits July 6, 2012 21:38
Image2D pnpoly update
dd3f2af
Updated polyfill[v] and pnpoly to have interfaces to allow for dynami…
bb70144 
…c selection of algorithm (classic polyfill vs. pnpolyfill_pp)
Merge remote-tracking branch 'origin' into image2D_pnpoly
8c784ef
Remove unpdl and IO::NDF updates from upstream
dbb130c
Merge branch 'image2D_pnpoly' of https://github.com/hainest/PDL into …
6a4b2a0 
…image2D_pnpoly
Merge branch 'image2D_pnpoly' of https://github.com/hainest/PDL
bea3491
Merge branch 'master' of https://github.com/PDLPorters/pdl
b0ad537
Add propagation of badflag with .= (Ops::assgn) for sf.net bug 3543056.
0729a63
Add propagation of badflag with .= (Ops::assgn) for sf.net bug 3543056.
6ea84da
Add propagation of badflag with .= (Ops::assgn) for sf.net bug 3543056.
121ae79 
Conflicts:
	Basic/Ops/ops.pd
Merge branch 'master' of https://github.com/hainest/PDL into assgn_ba…
83244fb 
…dflag
@run4flat
Copy link
Member

run4flat commented Jan 7, 2013

Sorry I've been sleeping on this for a while. Should I flag this for discussion on the PDL Porters list?

@hainest
Copy link
Author

hainest commented Jan 9, 2013

I don't think it was ever merged. Running it through the Porters list is a
good idea. There were some archeological conflicts that Doug Burke
mentioned in the code comments, but he is not currently certain that they
will still be an issue [as per his comments on the sf bug,
http://sourceforge.net/tracker/?func=detail&aid=3543056&group_id=612&atid=100612
]

Thanks!

On Mon, Jan 7, 2013 at 10:15 AM, run4flat notifications@github.com wrote:

Sorry I've been sleeping on this for a while. Was this ever merged? If
not, I can flag it for discussion on the PDL Porters list.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-11957812.

@zmughal
Copy link
Member

zmughal commented Mar 2, 2015

Is this PR still valid?

@mohawk2
Copy link
Member

mohawk2 commented Mar 2, 2015

Not as it stands - look at all those "merge" instead of rebasing!

@mohawk2 mohawk2 mentioned this pull request Mar 2, 2015
Merged
@mohawk2
Copy link
Member

mohawk2 commented Mar 2, 2015

Obsoleted by the passage of time, and #51.

@mohawk2 mohawk2 closed this Mar 2, 2015
@hainest
Copy link
Author

hainest commented Mar 3, 2015

Terribly sorry. I had completely forgotten about this. Thanks for chasing it down!

@mohawk2
Copy link
Member

mohawk2 commented Mar 3, 2015

Nothing to apologise for! Are you comfortable these days with rebasing? Are there other contributions you'd like to make to PDL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hainest @run4flat @zmughal @mohawk2