#TRUNK-3751: Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -347,6 +351,9 @@ public static void checkRequiredVersion(String version, String value) throws Mod | |||
| * @should treat SNAPSHOT as earliest version | |||
| */ | |||
| public static int compareVersion(String version, String value) { | |||
| String alphaVersion = ""; | |||
There was a problem hiding this comment.
I wouldn't call it alpha, rather a qualifier after maven version conventions. Please change all places that use alpha to qualifier.
|
These classes and methods were unrelated |
|
@jkondrat you have just reopened this. Did you address the review comments? |
|
@dkayiwa Changes in these classes were unrelated to this ticket, so I reverted them in my second commit. |
|
Can you squash these commits into one such that the pull request has only one commit to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.