Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline::CPP needs to bundle PRD in inc #12

Closed
ingydotnet opened this issue Dec 9, 2014 · 4 comments
Closed

Inline::CPP needs to bundle PRD in inc #12

ingydotnet opened this issue Dec 9, 2014 · 4 comments

Comments

@ingydotnet
Copy link
Owner

for now, since it only has a grammar for PRD.

Also we need to work out how I:CPP overrides grammars.

Probably needs to have separate grammar modules like Inline::C, and not just
override get_parser directly.
@daoswald
Copy link
Collaborator

I'm not sure on this (even though you are most likely right). PRD is only necessary when Inline::CPP is in use. That only happens when we're in development mode. Developers would already have installed Inline::CPP, and in so doing, would have pulled in the PRD dependency automatically.

@ingydotnet
Copy link
Owner Author

@daoswald, I think PRD is needed to build the installable .so during user
install. No?

@ingydotnet
Copy link
Owner Author

@daoswald, never heard back from you. Closing this now. I think PRD needs to be
bundled and it's currently working that way.

If you disagree, please repoen.

@daoswald
Copy link
Collaborator

You were right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ingydotnet @daoswald