Added order type custom getter methods as per TRUNK-4312 #777
+158
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Get all order types available with or without retired order types according to boolean flag | ||
| * | ||
| * @param includeRetired boolean flag which indicate search needs to look at retired order types or not | ||
| * @param includeRetired if set true then will return all order types include retired order types |
There was a problem hiding this comment.
I have misunderstood the @should use.Sorry will keep remind about the use
|
Looks good, i will address the comments and merge the code |
| @@ -267,7 +267,10 @@ | |||
| <order_type order_type_id="1" name="Drug order" description="Order of medications for the patient" creator="1" date_created="2008-08-15 13:49:47.0" retired="false" uuid="84ce45a8-5e7c-48f7-a581-ca1d17d63a62"/> | |||
| <order_type order_type_id="2" name="Lab test" description="An order by a clinician for a laboratory test" creator="1" date_created="2008-08-15 13:50:14.0" retired="false" uuid="f149b5e1-4314-4d0d-a95f-1c4f8031161d"/> | |||
| <order_type order_type_id="4" name="Lunch order" description="so hungry" creator="1" date_created="2008-08-15 15:49:04.0" retired="true" uuid="e23733ab-787e-4096-8ba2-577a902d2c2b"/> | |||
| <orders order_id="1" order_type_id="2" urgency="ROUTINE" concept_id="88" orderer="1" instructions="2x daily" start_date="2008-08-08 00:00:00.0" discontinued="true" discontinued_date="2008-08-15 00:00:00.0" discontinued_by="1" creator="1" date_created="2008-08-19 12:20:22.0" voided="false" patient_id="7" uuid="921de0a3-05c4-444a-be03-e01b4c4b9142"/> | |||
There was a problem hiding this comment.
You added these the wrong file, it should be in standardTestDataset.xml file, are you sure you ran the tests and they passed
There was a problem hiding this comment.
The reason they are passing is because you set up the test for including/excluding retired ones wrongly
|
Merged at e532b37 |
|
Do I need to do the necessary changes and create a pull request again? I saw this is committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.