Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: f92f1a0a8733
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: c7e261e1c4d3
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 13, 2012

  1. Show all users in assign filter when ALL PROJECTS is selected 

    Fixes #10130

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
    @dregad
    JGuilbaud authored and dregad committed Dec 13, 2012
    Copy the full SHA
    048dc22 View commit details
    Browse the repository at this point in the history

  2. Optimise code in print_user_option_list() 

    Improve performance of code building the list of users for all projects
introduced in commit 21746dd.

By using an associative array, the foreach loop to remove duplicates can
be simplified (no need for an if statement) and we can also remove the
current user from the list more easily.

Affects issue #10130
    @dregad
    dregad committed Dec 13, 2012
    Copy the full SHA
    dba4f3e View commit details
    Browse the repository at this point in the history

  3. Removing current user from list built by print_user_option_list() 

    Since there is a [myself] value in the list, the current user should be
removed. This was done for ALL_PROJECTS with the fix for issue #10130,
but the single-project code still listed the current user.

By moving the code to remove the current user to the foreach loop that
builds the sort arrays, we ensure that it is removed in both cases.
    @dregad
    dregad committed Dec 13, 2012
    Copy the full SHA
    c7e261e View commit details
    Browse the repository at this point in the history