Implement the checkbox control

hawtio · Apr 3, 2013 · 2aa16cc · 2aa16cc
1 parent 971a9ac
commit 2aa16cc
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 6 deletions.
diff --git a/hawtio-web/src/main/webapp/app/forms/html/test.html b/hawtio-web/src/main/webapp/app/forms/html/test.html
@@ -8,7 +8,7 @@ <h3>Form Testing</h3>
       <a class='btn' ng-href="" hawtio-reset='form-with-inline-arguments'><i class="icon-refresh"></i> Clear</a>
     </div>
     Form with inline arguments
-    <div simple-form name='form-with-inline-arguments' action='#/forms/test' method='post' data='setVMOption' entity='cheese' onSubmit="derp()" submitText="Derp"></div>
+    <div simple-form name='form-with-inline-arguments' action='#/forms/test' method='post' data='setVMOption' entity='cheese' onSubmit="derp()"></div>
   </div>
 
   <hr>
@@ -18,7 +18,7 @@ <h3>Form Testing</h3>
     <div class="row-fluid">
       <button class="btn" ng-click="toggleEdit()">Edit</button>
     </div>
-    <div simple-form='config' entity='cheese' mode='view'></div>
+    <div simple-form data='setVMOption' entity='cheese' mode='view'></div>
   </div>
 
   <hr>

diff --git a/hawtio-web/src/main/webapp/app/forms/js/baseDirectives.ts b/hawtio-web/src/main/webapp/app/forms/js/baseDirectives.ts
@@ -86,7 +86,7 @@ module Forms {
 
   export class TextInput extends InputBase {
 
-    public type="text";
+    public type = "text";
 
     constructor(private workspace, private $compile) {
       super(workspace, $compile);
@@ -235,10 +235,30 @@ module Forms {
       super(workspace, $compile);
     }
 
-    private doLink(scope, element, attrs) {
-      // TODO
-      console.log("BooleanInput");
+    public getInput(config, arg, id) {
+
+      var rc = $('<input class="hawtio-checkbox" type="checkbox">');
+      rc.attr('name', id);
+
+      if (config.isReadOnly()) {
+        rc.attr('disabled', 'true');
+      }
+
+      var modelName = arg.model;
+      if (!angular.isDefined(arg.model)) {
+        // TODO always use 2 way binding?
+        modelName = config.getEntity() + "." + id;
+      }
+      if (modelName) {
+        rc.attr('ng-model', modelName);
+      }
+      if (config.isReadOnly()) {
+        rc.attr('readonly', 'true');
+      }
+      return rc;
     }
+
+
   }
 
 

diff --git a/hawtio-web/src/main/webapp/app/forms/js/formPlugin.ts b/hawtio-web/src/main/webapp/app/forms/js/formPlugin.ts
@@ -24,6 +24,9 @@ module Forms {
           directive('hawtioFormObject', function(workspace, $compile) {
             return new Forms.ObjectInput(workspace, $compile);
           }).
+          directive('hawtioFormCheckbox', function(workspace, $compile) {
+            return new Forms.BooleanInput(workspace, $compile);
+          }).
           directive('hawtioSubmit', function() {
             return new Forms.SubmitForm();
           }).

diff --git a/hawtio-web/src/main/webapp/app/forms/js/mappingRegistry.ts b/hawtio-web/src/main/webapp/app/forms/js/mappingRegistry.ts
@@ -24,6 +24,10 @@ module Forms {
       case "object":
       case "java.lang.object":
         return "hawtio-form-object";
+      case "boolean":
+      case "bool":
+      case "java.lang.boolean":
+        return "hawtio-form-checkbox";
       default:
         // lets check if this name is an alias to a definition in the schema
         return "hawtio-form-text";

diff --git a/hawtio-web/src/main/webapp/app/forms/js/test.ts b/hawtio-web/src/main/webapp/app/forms/js/test.ts
@@ -38,6 +38,10 @@ module Forms {
         'objectArg': {
           description: 'some object',
           type: 'object'
+        },
+        'booleanArg': {
+          description: 'Some boolean value',
+          type: 'java.lang.Boolean'
         }
         // TODO - add more types, above is what I remember from jolokia
       },

diff --git a/hawtio-web/src/main/webapp/css/site-base.css b/hawtio-web/src/main/webapp/css/site-base.css
@@ -897,3 +897,7 @@ div#main div div div div div.logbar div.logbar-container ul.nav.nav-tabs {
   display: inline-block;
   margin: 5px;
 }
+
+input[type="checkbox"].hawtio-checkbox {
+  margin-top: 10px;
+}