Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small issues fixed, see commits #545

Closed
wants to merge 10 commits into from
Closed

A few small issues fixed, see commits #545

wants to merge 10 commits into from

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Jun 17, 2013

No description provided.

Spuds added 10 commits June 16, 2013 20:22
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
! minor formatting updates
Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
@norv
Copy link
Contributor

norv commented Jun 17, 2013

Just to note. What I would do, more often than not, is rebase (on an updated master), instead of merge. In particular for a branch in progress which hasn't been submitted yet. It's a "similar" thing, but rebase will reset the working branch to the top of the master, then it will try to re-apply the existing commits of the working branch on top of it, as if it was just created from it.
It ends up with a cleaner history, where if there were conflicts it would be very easy to spot and track if anything is missed (because conflicts wouldn't be on merge commits, they would be on atomic commits, so 'smaller' both during rebase and afterwards in history).

Also rebase would also allow easier to rebase again (to squash commits for example, if wanted.)

Please note, I'm not suggesting to do anything on this PR. It just reminded me of this detail.

@norv norv mentioned this pull request Jun 17, 2013
@norv norv closed this Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants