Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tombstone resources when getting a resource's children #561

Merged
merged 1 commit into from Oct 21, 2014

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Oct 19, 2014

return (isInternalNode.apply(n) || n.getName().equals(JCR_CONTENT));
return isInternalNode.apply(n)
|| n.getName().equals(JCR_CONTENT)
|| TombstoneImpl.hasMixin(n);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very small, but it might be better to call the method isTombstone or something like that instead of hasMixin. Might be a little more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but we're already using hasMixin on all the other models.

awoods pushed a commit that referenced this pull request Oct 21, 2014
Exclude tombstone resources when getting a resource's children
@awoods awoods merged commit 8dea13f into master Oct 21, 2014
@awoods awoods deleted the exclude-tombstones branch October 21, 2014 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants