Fix X86 MACRO #3193
Merged
Fix X86 MACRO #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is necessary to not consider 64bit architecture as always X86.
|
Could you please explain more about why this change is necessary? Also, why wouldn't this become two separate branches? There are also other conditionals exactly like this, so why aren't they changed? Perhaps we need to define a specific macro and then use that in later conditionals. |
|
@brixen: The only reason I separate is because the Travis was breaking the building, and then he returned to build normally (I don't know why, sorry). |
|
@gustavotemple ok, got it. Thanks for explaining. |
|
@brixen, no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary to not consider all the
64bit architectures as always X86.