New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajax something #407
Ajax something #407
Conversation
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…mark board read" and "mark all messages as read" in an ajax fashion Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Yup missed it, just like I missed that we upped the min version to php 5.2 ... |
We did? |
/me should now learn to read manuals... 👼 Well, not really, the PR is not merged yet. ;) |
Ahh. json_encode? Heh. We got carried away, huh? |
Yup ... jumped right out at me .... well after I came to after seeing that e-man had done some code documentation :P |
Thanks for the reminder! I totally didn't notice, and I don't think Ema did either. Josh almost got us 😉 👼 |
LMAO... almost. You'd find out who was actually using 5.1 ;-) |
Discussing it is fine, knowingly stuffing it in as "fun" I personally find disrespectful. |
I didn't mean that at all. I didn't realize it was 5.2 until it was mentioned in IRC. I don't remember the last time I worried about < 5.2. |
Don't worry, even the dinosaur named Debian "Etch"is 5.2.0.8. |
I introduced it without realising. I'll remove the code later today. |
Signed-off-by: emanuele <emanuele45@gmail.com>
Conflicts: themes/default/MessageIndex.template.php
Updated and fixed the merge. |
Thank you! I'm merging this, it's a very nice step overall. For the 'ajaxify' functionality it starts to introduce, which will make it nice and handy for people. And not only IMHO: also it shows us how we can integrate new request handlers and even new types of requests, using our mechanisms in place. (dispatching, proper controllers) |
Very nice addition indeed ... and apologize for my harsh tone! |
Somewhere around there is also some refactoring...
/me is innocent... 👼
That's the basic, someone else can add fancy effects and alike. 😛