Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax something #407

Merged
merged 17 commits into from May 17, 2013
Merged

Ajax something #407

merged 17 commits into from May 17, 2013

Conversation

emanuele45
Copy link
Contributor

Somewhere around there is also some refactoring...

/me is innocent... 👼

That's the basic, someone else can add fancy effects and alike. 😛

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…mark board read" and "mark all messages as read" in an ajax fashion

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@Spuds
Copy link
Contributor

Spuds commented May 16, 2013

Yup missed it, just like I missed that we upped the min version to php 5.2 ...

@norv
Copy link
Contributor

norv commented May 16, 2013

We did?

@emanuele45
Copy link
Contributor Author

/me should now learn to read manuals... 👼

Well, not really, the PR is not merged yet. ;)

@norv
Copy link
Contributor

norv commented May 16, 2013

Ahh. json_encode?

Heh. We got carried away, huh?

@Spuds
Copy link
Contributor

Spuds commented May 16, 2013

Yup ... jumped right out at me .... well after I came to after seeing that e-man had done some code documentation :P

@norv
Copy link
Contributor

norv commented May 16, 2013

Thanks for the reminder! I totally didn't notice, and I don't think Ema did either. Josh almost got us 😉 👼

@joshuaadickerson
Copy link
Contributor

LMAO... almost. You'd find out who was actually using 5.1 ;-)

@Spuds
Copy link
Contributor

Spuds commented May 17, 2013

Discussing it is fine, knowingly stuffing it in as "fun" I personally find disrespectful.

@joshuaadickerson
Copy link
Contributor

I didn't mean that at all. I didn't realize it was 5.2 until it was mentioned in IRC. I don't remember the last time I worried about < 5.2.

@eurich
Copy link
Member

eurich commented May 17, 2013

Don't worry, even the dinosaur named Debian "Etch"is 5.2.0.8.
If necessary we could emulate json_encode(); http://www.boutell.com/scripts/jsonwrapper.html

@emanuele45
Copy link
Contributor Author

I introduced it without realising.
I don't think that at this point introduce some random JSON functions without any real use in core with a bunch of code for compatibility is really worth the hassle.
If there was an actual use of json in the code yes, but like that no.

I'll remove the code later today.
Thanks @Spuds for noting it!

Signed-off-by: emanuele <emanuele45@gmail.com>
Conflicts:
	themes/default/MessageIndex.template.php
@emanuele45
Copy link
Contributor Author

Updated and fixed the merge.

norv added a commit that referenced this pull request May 17, 2013
@norv norv merged commit 770de1a into elkarte:master May 17, 2013
@norv
Copy link
Contributor

norv commented May 17, 2013

Thank you! I'm merging this, it's a very nice step overall. For the 'ajaxify' functionality it starts to introduce, which will make it nice and handy for people. And not only IMHO: also it shows us how we can integrate new request handlers and even new types of requests, using our mechanisms in place. (dispatching, proper controllers)
I think it's better off to see it at work.

@Spuds
Copy link
Contributor

Spuds commented May 17, 2013

Very nice addition indeed ... and apologize for my harsh tone!

@norv norv mentioned this pull request May 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants