TRUNK-3871 - Create UserService.saveUser(User user) method #362
Conversation
| @@ -53,15 +53,33 @@ | |||
| * @should grant new roles in roles list to user | |||
| * @should fail to create the user with a weak password | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
I prefer we stay with this rather undeprecating createUser, by convention we replaced createXXX methods with saveXXX so this is going backwards, i believe we just need to well document both saveUser method about what they do.
There was a problem hiding this comment.
You will to add some unit tests if they are none for these methods to test the new behavior
|
@akolodziejski can you squash these commits into one? You can use the instructions at: https://wiki.openmrs.org/display/docs/Using+Git |
|
@akolodziejski can you pull the latest changes from upstream and then resolve conflicts? You can take a look at: http://go.openmrs.org/pull-request-tips |
cleaned Typographical error TRUNK-3405 added function to create dwr-modules.xml in webmoduleUtil.java + added 2 unit tests in webModuleUtilTest.java back to 745 - due to stashing Added break statement on line 106 of webmoduleUtilTest.java TRUNK-3405 - minor changes TRUNK-3405 - removed unnecessary lines TRUNK-3405 - added function getRealPath() Ticket-2873:Improve wording for Testing option in installation wizard TRUNK-4166: Added check in BaseAttributeTypeValidator to prevent DatatypeConfiguration to be blank if Datatype is equal to Regex-Validated Text TRUNK-4166 added junit test in BaseAttributeTypeValidatorTest TRUNK-3871 - Create UserService.saveUser(User user) method TRUNK-3871 - Create UserService.saveUser(User user) method TRUNK-3871 - Create UserService.saveUser(User user) method TRUNK-3871 Create UserService.saveUser(User user) method - addressed review comment TRUNK-3871 addressing review comments v2
|
I did sth wrong :/ I will need help with git. Could someone help me with git ? ( via chat or Skype) |
|
Have you read the whole of this? On Thu, Mar 20, 2014 at 11:44 PM, akolodziejski notifications@github.comwrote:
If we keep uppermost in our minds the unkind and unjust acts of others, we |
|
@akolodziejski i can reopen this after you have addressed the above comments. |
This PR fixes file names in the login app so they follow our naming convention.
TRUNK-3871 - Create UserService.saveUser(User user) method