check for null references on $destroy and updateGridLayout #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm affected by this as well, see avantgarde-labs/ng-grid@17f093f |
c0bra
added a commit
that referenced
this pull request
Apr 24, 2014
…stroy check for null references on $destroy and updateGridLayout
|
Thanks for the PR! Sorry I didn't catch this in testing. |
|
@c0bra This fix was merged to 2.0.8 which has an angular dependency problem, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #1130 ( admittedly hacky )
It's defensive in nature and just checks if references are null before calling a method on them. I was running into instances where on routeChange, $destroy was being called several times and throwing an error.