Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 454ed8f0e1fd
Choose a base ref
...
head repository: cdk/cdk
compare: 55e30c698a6e
Choose a head ref
  • 6 commits
  • 39 files changed
  • 1 contributor

Commits on Apr 6, 2014

  1. We can correctly define the descriptors exported by each module. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Apr 6, 2014
    Copy the full SHA
    73f9148 View commit details
    Browse the repository at this point in the history

  2. Move resources files required by cdh-hash to that module and eliminat… 

    …es dependence on testdata.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Apr 6, 2014
    Copy the full SHA
    43e6ee3 View commit details
    Browse the repository at this point in the history

  3. Move the hash resources files to the same package as the test that ne… 

    …eds them.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Apr 6, 2014
    Copy the full SHA
    3e0b405 View commit details
    Browse the repository at this point in the history

  4. Dependencies that can be safely removed from cdk-group and cdk-hash. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Apr 6, 2014
    Copy the full SHA
    898e3ae View commit details
    Browse the repository at this point in the history

  5. We can remove the dependence on cdk-extra and valency check by not us… 

    …e the MoleculeFactory. Using cdk-data (test) isn't ideal but is better than extra.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Apr 6, 2014
    Copy the full SHA
    17b5f5b View commit details
    Browse the repository at this point in the history

  6. Move test resources to be local to the test that requires them. These… 

    … files in particularly have been reused in pcore/io so the originals have been left in place for the moment.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Apr 6, 2014
    Copy the full SHA
    55e30c6 View commit details
    Browse the repository at this point in the history