Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UiSrefActive should support multiple UiSref directives #1129

Closed
wants to merge 1 commit into from

Conversation

tomekpiotrowski
Copy link

No description provided.

@christopherthielen
Copy link
Contributor

We have a few ui-sref-active PR floating around.

I think I agree with the spirit of this one, but we'll need to make sure all the changes to uiSrefActive make sense together.

@ProLoser
Copy link
Member

@tomekpiotrowski I'm closing this as it's a little overly complicated. If you need anything other than the current state match or an ancestor match write your own function and use ng-class or a custom directive. I'd prefer to see something like specifying a shared parent state instead of listing multiple children in an html attribute.

@ProLoser ProLoser closed this Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants