Allow content types to be overriden when downloading files

rombert · rombert · commit fbac390060c7 · 2011-12-07T01:49:53.000+02:00
Fixes #13439: Wrong Content-type for various MSOffice documents
diff --git a/config_defaults_inc.php b/config_defaults_inc.php
@@ -3486,6 +3486,22 @@
 	'zip'	=> 'zip.gif',
 	'?'	=> 'generic.gif' );
 
+/**
+ * 
+ * Content types which will be overriden when downloading files
+ * 
+ * @global array $g_file_download_content_type_overrides
+ */
+$g_file_download_content_type_overrides = array (
+	'docx' => 'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+	'dotx' => 'application/vnd.openxmlformats-officedocument.wordprocessingml.template',
+	'pptx' => 'application/vnd.openxmlformats-officedocument.presentationml.presentation',
+	'ppsx' => 'application/vnd.openxmlformats-officedocument.presentationml.slideshow',
+	'potx' => 'application/vnd.openxmlformats-officedocument.presentationml.template',
+	'xlsx' => 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+	'xltx' => 'application/vnd.openxmlformats-officedocument.spreadsheetml.template'
+);
+
 /**
  * Icon associative arrays
  * Status to icon mapping
diff --git a/core/file_api.php b/core/file_api.php
@@ -1063,3 +1063,18 @@ function file_copy_attachments( $p_source_bug_id, $p_dest_bug_id ) {
         db_query_bound( $query, Array( $p_dest_bug_id, $t_bug_file['title'], $t_bug_file['description'], $t_new_diskfile_name, $t_new_file_name, $t_bug_file['folder'], $t_bug_file['filesize'], $t_bug_file['file_type'], $t_bug_file['date_added'], $t_bug_file['content'] ) );
     }
 }
+
+/**
+ * Returns a possibly override content type for a file name
+ * 
+ * @param string $p_filename the filename of the file which will be downloaded
+ * @return string the content type, or empty if it should not be overriden
+ */
+function file_get_content_type_override( $p_filename ) {
+	
+	global $g_file_download_content_type_overrides;
+	
+	$t_extension = pathinfo( $p_filename, PATHINFO_EXTENSION );
+	
+	return $g_file_download_content_type_overrides[$t_extension];
+}
diff --git a/file_download.php b/file_download.php
@@ -167,6 +167,8 @@
 
 $t_content_type = $v_file_type;
 
+$t_content_type_override = file_get_content_type_override ( $t_filename );
+
 # dump file content to the connection.
 switch ( config_get( 'file_upload_method' ) ) {
 	case DISK:
@@ -180,6 +182,9 @@
 					$t_content_type = $t_file_info_type;
 				}
 			}
+			
+			if ( $t_content_type_override )
+				$t_content_type = $t_content_type_override;
 
 			header( 'Content-Type: ' . $t_content_type );
 			if ( config_get( 'file_download_xsendfile_enabled' ) ) {
@@ -206,6 +211,9 @@
 				$t_content_type = $t_file_info_type;
 			}
 		}
+		
+		if ( $t_content_type_override )
+			$t_content_type = $t_content_type_override;
 
 		header( 'Content-Type: ' . $t_content_type );
 		readfile( $t_local_disk_file );
@@ -218,6 +226,9 @@
 				$t_content_type = $t_file_info_type;
 			}
 		}
+		
+		if ( $t_content_type_override )
+			$t_content_type = $t_content_type_override;
 
 		header( 'Content-Type: ' . $t_content_type );
 		echo $v_content;

Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,8 @@`
`167`	`167`
`168`	`168`	`$t_content_type = $v_file_type;`
`169`	`169`
	`170`	`+$t_content_type_override = file_get_content_type_override ( $t_filename );`
	`171`	`+`
`170`	`172`	`# dump file content to the connection.`
`171`	`173`	`switch ( config_get( 'file_upload_method' ) ) {`
`172`	`174`	`case DISK:`
`@@ -180,6 +182,9 @@`
`180`	`182`	`$t_content_type = $t_file_info_type;`
`181`	`183`	`}`
`182`	`184`	`}`
	`185`	`+`
	`186`	`+ if ( $t_content_type_override )`
	`187`	`+ $t_content_type = $t_content_type_override;`
`183`	`188`
`184`	`189`	`header( 'Content-Type: ' . $t_content_type );`
`185`	`190`	`if ( config_get( 'file_download_xsendfile_enabled' ) ) {`
`@@ -206,6 +211,9 @@`
`206`	`211`	`$t_content_type = $t_file_info_type;`
`207`	`212`	`}`
`208`	`213`	`}`
	`214`	`+`
	`215`	`+ if ( $t_content_type_override )`
	`216`	`+ $t_content_type = $t_content_type_override;`
`209`	`217`
`210`	`218`	`header( 'Content-Type: ' . $t_content_type );`
`211`	`219`	`readfile( $t_local_disk_file );`
`@@ -218,6 +226,9 @@`
`218`	`226`	`$t_content_type = $t_file_info_type;`
`219`	`227`	`}`
`220`	`228`	`}`
	`229`	`+`
	`230`	`+ if ( $t_content_type_override )`
	`231`	`+ $t_content_type = $t_content_type_override;`
`221`	`232`
`222`	`233`	`header( 'Content-Type: ' . $t_content_type );`
`223`	`234`	`echo $v_content;`