This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Persist jcr/xml in hierarchy path structure. #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,12 +76,24 @@ public JcrXmlPersistenceIndexer(final String pathName) { | |||
|
|
|||
| @Override | |||
| public File call() throws IOException { | |||
| // strip http protocol and replace column(:) | |||
| String fullPath = id.substring(id.indexOf("//") + 2).replace(":", "/"); | |||
There was a problem hiding this comment.
Many identifiers will be of the form "pid:55".
I suspect we only want to replace the ":" if it is associated with a port, not all colons.
However, we should appropriately encode the URI that is being converted to a directory path so that the converted characters are valid on the three filesystems: Mac, Windows, Linux
path as suggested.
|
Resolved with: 9815690 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/s/projects/684825/stories/75644184
I've updated it to persist the jcr/xml as suggested: a structure like [basedir]/localhost/8080/rest/123.jcr.xml.