Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 2dd4a745b0ec
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: dfb0461c4cfb
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Aug 17, 2013

  1. readline: pause stdin before turning off terminal raw mode 

    On windows, libuv will immediately make a `ReadConsole` call (in the
thread pool) when a 'flowing' `uv_tty_t` handle is switched to
line-buffered mode. That causes an immediate issue for some users,
since libuv can't cancel the `ReadConsole` operation on Windows 8 /
Server 2012 and up if the program switches back to raw mode later.

But even if this will be fixed in libuv at some point, it's better to
avoid the overhead of starting work in the thread pool and immediately
cancelling it afther that.

See also f34f1e3, where the same change is made for the opposite
flow, e.g. move `resume()` after `_setRawMode(true)`.

Fixes #5927
Closes #5930
    @danielchatfield @piscisaureus
    danielchatfield authored and piscisaureus committed Aug 17, 2013
    Copy the full SHA
    dfb0461 View commit details
    Browse the repository at this point in the history