Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis case for testing not blib but installed #98

Merged
merged 8 commits into from Apr 11, 2015

Conversation

mohawk2
Copy link
Member

@mohawk2 mohawk2 commented Apr 10, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.42% when pulling a35b66a on travis-testinstall into babaa0e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.42% when pulling 75732eb on travis-testinstall into babaa0e on master.

@mohawk2
Copy link
Member Author

mohawk2 commented Apr 11, 2015

Build 178, with the above fixes, is now failing in only the way it's supposed to, as opposed to the extra bonus ways it failed before. The build with @drzowie's added commit should then pass.

@zmughal, could you review these changes? If you're content (and Travis passes correctly), I'll merge to master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) to 62.42% when pulling 5148b8b on travis-testinstall into babaa0e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 62.4% when pulling 5148b8b on travis-testinstall into babaa0e on master.

@zmughal
Copy link
Member

zmughal commented Apr 11, 2015

This is looking good. I went over the changes and it's some nice work. Quite a bit of cleanup involved. .travis.yml changes are reasonable too.

Yep, I see the inline test failing in Build 178. Build 179 with @drzowie's changes passes!

@mohawk2 mohawk2 merged commit 5148b8b into master Apr 11, 2015
@mohawk2 mohawk2 deleted the travis-testinstall branch April 11, 2015 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants