added web-deployable implementation #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </configuration> | ||
| </plugin> | ||
|
|
||
| <!-- plugin to deploy to JBoss AS with: mvn jboss-as:deploy (you can also do redeploy/undeploy) --> |
There was a problem hiding this comment.
Agreed, let's not introduce JBoss AS deployment.
|
Very nice. Quickly starting:
immediately revealed audit events via SPARQL-Queries. 👍 |
|
Any opinions on the default value for the Audit Event BaseURI? I've got |
|
http://example.com/event seems good to me |
…n; add documentation
|
Merged as three squashed commits. Starting with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a web-deployable audit service based on the camel routes in
audit-triplestore, mostly resolving: https://jira.duraspace.org/browse/FCREPO-1452There is some (minor) cleanup that should still be done, such as:
The
audit-triplestore-web/pom.xmlfile can be cleaned up a bit; also there are no tests to speak of (I'm hoping that someone with more experience with Tomcat can do that -- basically just a sanity check). Also, are the jboss-related maven configs necessary? (feel free to remove them)Finally, the jms configuration (in
applicationContext.xml) should be made to be configurable from a system value (or property placeholder)