[Truffle] Move Regexp#=== to regexp.rb. #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like Rubinius does a check on whether the object can coerce to a string and if not, returns false: https://github.com/rubinius/rubinius/blob/v2.4.1/kernel/common/regexp.rb#L192-L198 |
bjfish
force-pushed
the
truffle_regexp_case_equals
branch
2 times, most recently
from
592d21f
to
bfb6430
Compare
bjfish
force-pushed
the
truffle_regexp_case_equals
branch
from
bfb6430
to
ad97895
Compare
bjfish
changed the title
nirvdrum
added a commit
that referenced
this pull request
Apr 13, 2015
[Truffle] Move Regexp#=== to regexp.rb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a case where this is true?