New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assgn badflag #96
Assgn badflag #96
Conversation
…c selection of algorithm (classic polyfill vs. pnpolyfill_pp)
…image2D_pnpoly
Conflicts: Basic/Ops/ops.pd
6b24622
to
efaeee7
Compare
Tim, I assume this is good stuff. However, I'm guessing you meant to PR 1 commit, not 72. This branch has all of the "merge" stuff we already talked about as making the PR-evaluator/merge's life hard, along with a new even-larger "merge" commit: the penultimate one changes 361 files. If you'd like to make things easier for everyone (especially you!) going forward, and use git like a pro, read on. If this is too much of a diversion from things that are more important to you, let me know and I'll pull out what I can from the PR as currently is. If you have questions about this stuff, feel free to join IRC on I've brought the PDLPorter repo's
Please put a comment on here when you've done this since github won't tell me when you've updated it. |
efaeee7
to
22d290a
Compare
Ah! No, I definitely didn't mean to submit 72 commits! I don't normally work with rebased repos, so I greatly appreciate you outlining how to use that. I have received notice that the assgn_badflag branch was merged with master, so I am assuming you took care of that. If so, thanks! |
Whatever notice you received was incorrect. It is not merged, as we are too close to a release for this kind of late change. However I am very keen for this work to be completed and for it to improve a near-future release! Once again, please action my suggestions above and fix up your work so it is of use. |
Updated repo version of #51 (comment) and a little cleanup in t/ops.t.