code cleanup; decouple route processing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoods
pushed a commit
that referenced
this pull request
Apr 13, 2015
code cleanup; decouple route processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses: https://jira.duraspace.org/browse/FCREPO-1459
In addition, it cleans up the code significantly by adding a dedicated AuditHeader class for headers such as the one for the
event.baseUriproperty, using a more standard Camel format. It also puts the RDF namespaces into a shared location for easier re-use.The
EventRouterclass has been pulled apart into two simple routes, and the testing has been bifurcated into tests that verify the Processor classProcessorTestand tests that check the actual RoutesRouteTest. TheRouteTestsmake significant use of theAdviceWithfeatures so that we can bypass the need for an actual JMS broker in the unit tests. Doing so makes the tests run much faster as all the processor tests don't keep trying to connect to a local JMS broker.