Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] Add a string specialization to Module#alias_method. #2829

Merged
merged 1 commit into from Apr 13, 2015
Merged

[Truffle] Add a string specialization to Module#alias_method. #2829

merged 1 commit into from Apr 13, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 13, 2015

No description provided.

@nirvdrum
Copy link
Contributor

I suspect we'll need to deal with various combinations of these at some point. And maybe ever coercible types. But looks good.

nirvdrum added a commit that referenced this pull request Apr 13, 2015
@nirvdrum
Merge pull request #2829 from bjfish/truffle_module_alias_string
56046df 
[Truffle] Add a string specialization to Module#alias_method.
@nirvdrum nirvdrum merged commit 56046df into jruby:master Apr 13, 2015
@nirvdrum
Copy link
Contributor

If we do need to coerce, SymbolOrToStrNode might be a good starting point.

@chrisseaton chrisseaton modified the milestone: truffle-dev May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bjfish @nirvdrum @enebo @chrisseaton