[Truffle] Do not leave the lock as StringFormatter calls Ruby code (t…

…o_s).
jruby · Apr 14, 2015 · 66f45f7 · 66f45f7
1 parent 40e8c62
commit 66f45f7
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/KernelNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/KernelNodes.java
@@ -1906,14 +1906,7 @@ public RubyString sprintf(Object[] args) {
                 final String format = args[0].toString();
                 final List<Object> values = Arrays.asList(args).subList(1, args.length);
 
-                final RubyThread runningThread = getContext().getThreadManager().leaveGlobalLock();
-
-                try {
-                    // TODO(CS): this is only safe if values' toString() are pure.
-                    StringFormatter.format(getContext(), printStream, format, values);
-                } finally {
-                    getContext().getThreadManager().enterGlobalLock(runningThread);
-                }
+                StringFormatter.format(getContext(), printStream, format, values);
             }
 
             return getContext().makeString(new ByteList(outputStream.toByteArray()));