Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resourceModification as a supertype of contentModification & metadataModification #25

Closed
wants to merge 3 commits into from

Conversation

escowles
Copy link
Contributor

  • clarifying descriptions to indicate which types apply to files/bitstreams, metadata, or both

Addresses https://jira.duraspace.org/browse/FCREPO-1475

@escowles
Copy link
Contributor Author

@ajs6f @acoburn @awoods : does this make it clearer which types apply to bitstreams vs. metadata?

<skos:definition xml:lang="en">A content file or metadata is modified.</skos:definition>
<skos:inScheme rdf:resource="http://id.loc.gov/vocabulary/preservation/eventType"/>
<skos:inScheme rdf:resource="http://id.loc.gov/vocabulary/preservation"/>
<skos:narrower rdf:resource="http://fedora.info/definitions/v4/audit#bitstreamModification"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:
<skos:narrower rdf:resource="http://fedora.info/definitions/v4/audit#contentModification"/>
??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought resourceModification was the top of the mods?

@ajs6f
Copy link
Contributor

ajs6f commented Apr 17, 2015

Just to be clear, we're explaining removal as something disjoint with modification? Of course I'm fine with that, but we might want to add some owl:differentFrom incantations to that effect. Some people think of removal as being a kind of modification. (This is just a matter of natural language usage-- I just want to be as clear as possible and maybe a bit more.)

@escowles
Copy link
Contributor Author

@ajs6f yes, the intention is for removal to be when a node/bitstream is deleted, and modification when it is updated. Neither OWL nor SKOS has great vocabulary for expressing that they are disjoint, but I can add owl:differentFrom assertions (or just a owl:AllDifferent block saying all four individuals are different).

@ajs6f
Copy link
Contributor

ajs6f commented Apr 17, 2015

Cool, we're on the same page. Yeah, OWL in particular wants to be real careful about disjointness because of the anti-UNA attitude that comes with a global field of work, but I think we're justified here. And AllDifferent is better.

@awoods
Copy link

awoods commented Apr 23, 2015

Resolved with: c77d81b

@awoods awoods closed this Apr 23, 2015
@awoods awoods deleted the audit-ontology-update branch April 23, 2015 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants