Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Add pathname to the stdlib. #2822

Merged
merged 1 commit into from Apr 14, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 12, 2015

No description provided.

@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 12, 2015
@chrisseaton
Copy link
Contributor

Just waiting for pre2 still.

I was going to say I'm so happy that all but two of the specs pass, but then I looked and there isn't a lot of spec coverage here anyway. Hopefully the MRI test suite will help us more here.

chrisseaton added a commit that referenced this pull request Apr 14, 2015
[Truffle] Add pathname to the stdlib.
@chrisseaton chrisseaton merged commit a85f37d into jruby:master Apr 14, 2015
@eregon
Copy link
Member

eregon commented Apr 14, 2015

Not so much in MRI tests either (except for pure string manipulation), and we would probably fail a lot since this is filesystem-related for many things.
I once wrote a pathname library with a pretty decent test coverage (also revealing alternative impls fail many of these):
https://github.com/eregon/path
I might integrate those into RubySpec one day.

@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants