Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] Glob Issue needed for MRI tests #2825

Closed
bjfish opened this issue Apr 13, 2015 · 6 comments
Closed

[Truffle] Glob Issue needed for MRI tests #2825

bjfish opened this issue Apr 13, 2015 · 6 comments
Assignees
@chrisseaton
Milestone
Invalid or Duplicate

Comments

@bjfish
Copy link
Contributor

bjfish commented Apr 13, 2015

Sample Code (you'll need to just the path here to your test_alias.rb path):

path = "/Users/brandonfish/Documents/jruby-mine/test/mri/ruby/test_alias.rb"
testfile_prefix = "test"
emb = "#{path}/**/#{testfile_prefix}_*.rb"
puts emb
puts Dir[emb].to_s

Expected:

/Users/brandonfish/Documents/jruby-mine/test/mri/ruby/test_alias.rb/**/test_*.rb
[]

Actual:

/Users/brandonfish/Documents/jruby-mine/test/mri/ruby/test_alias.rb/**/test_*.rb
["/Users/brandonfish/Documents/jruby-mine/test/mri/ruby/test_alias.rb"]
@bjfish
Copy link
Contributor Author

bjfish commented Apr 14, 2015

The change in unit.rb where it says if false can be used to workaround this issue to run jt test mri tests:
https://gist.github.com/bjfish/1be84623da4a746f4d16

@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 14, 2015
@chrisseaton
Copy link
Contributor

I'm working on this at the moment - ended up pulling in a lot of new code to make it work and just fixing some bugs now.

@chrisseaton
Copy link
Contributor

Fixed in 3063622

@bjfish
Copy link
Contributor Author

bjfish commented Apr 18, 2015

@chrisseaton Re-opening because seeing the following error with the example:

/Users/brandonfish/Documents/jruby-mine/test/mri/ruby/test_alias.rb/**/test_*.rb
core:/core/rubinius/common/dir_glob.rb:107:in `const_missing': uninitialized constant Errno::ENOTDIR (NameError)
    from core:/core/rubinius/common/dir_glob.rb:107:in `call'
    from core:/core/rubinius/common/dir_glob.rb:63:in `call'
    from core:/core/rubinius/common/dir_glob.rb:84:in `call'
    from core:/core/rubinius/common/dir_glob.rb:324:in `run'
    from core:/core/rubinius/common/dir_glob.rb:402:in `glob'
    from core:/core/rubinius/common/dir.rb:64:in `block in glob'
    from core:/core/rubinius/common/dir.rb:61:in `each'
    from core:/core/rubinius/common/dir.rb:61:in `glob'
    from core:/core/rubinius/common/dir.rb:44:in `[]'
    from glob.rb:5:in `<main>'

@bjfish bjfish reopened this Apr 18, 2015
@chrisseaton
Copy link
Contributor

Ok - this should get resolved as part of my general overhaul of IO.

@chrisseaton chrisseaton self-assigned this Apr 18, 2015
@bjfish bjfish mentioned this issue Apr 20, 2015
Merged
@chrisseaton
Copy link
Contributor

Fixed in #2866

@enebo enebo added this to the Invalid or Duplicate milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisseaton chrisseaton

Labels
None yet
Projects
None yet
Milestone
Invalid or Duplicate
Development

No branches or pull requests
3 participants
@enebo @bjfish @chrisseaton