-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] Regex compile error in rexml #2853
Comments
Smaller test case is just: /[\u{10000}-\u{EFFFF}]/u |
I think this is ultimately the same problem as #2802. We need to take a pass on the encoding stuff in our Regexp implementation. |
Closed the wrong regex issue |
@bjfish is this blocking something you are working on? I don't think we'll solve this very soon unless it's critical for something and can't be worked around. |
@chrisseaton I am not actively working on this. This is just to track this issue which is blocking adding the REXML std lib. |
What uses REXML these days? |
@nirvdrum This compiles now with the your recent updates. There's an issue using the compiled regex now: NCNAME_STR = '[A-Z_a-z\u00C0-\u00D6\u00D8-\u00F6\u00F8-\u02FF\u0370-\u037D\u037F-\u1FFF\u200C-\u200D\u2070-\u218F\u2C00-\u2FEF\u3001-\uD7FF\uF900-\uFDCF\uFDF0-\uFFFD\u{10000}-\u{EFFFF}][A-Z_a-z\u00C0-\u00D6\u00D8-\u00F6\u00F8-\u02FF\u0370-\u037D\u037F-\u1FFF\u200C-\u200D\u2070-\u218F\u2C00-\u2FEF\u3001-\uD7FF\uF900-\uFDCF\uFDF0-\uFFFD\u{10000}-\u{EFFFF}\-\.0-9\u00B7\u0300-\u036F\u203F-\u2040]*'
NAMESPLIT = /^(?:(#{NCNAME_STR}):)?(#{NCNAME_STR})/u
puts ("root" =~ NAMESPLIT).to_s
puts "Done" Expected:
Actual
|
I still have a fair bit more to do. Just getting basic encoding support in caused a 89 failures & errors combined. Working through those took up most of my time. Let's put this issue on hold until I get all the Regexp specs passing (which should also get all the String specs passing). |
Example
Expected (ruby, jruby)
Actual
The text was updated successfully, but these errors were encountered: