Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Adding initial MRI test index and excludes. #2852

Merged
merged 1 commit into from Apr 21, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 19, 2015

No description provided.

@eregon
Copy link
Member

eregon commented Apr 20, 2015

Did you use a script to generate the excludes?

@chrisseaton
Copy link
Contributor

Didn't you still need #2826 to run these?

@bjfish bjfish force-pushed the truffle_mri_index_excludes branch from 5c32c81 to 5999203 Compare April 20, 2015 13:23
@bjfish
Copy link
Contributor Author

bjfish commented Apr 20, 2015

@chrisseaton Yes, it needs this to run test/unit unmodified #2826 and also these: #2836, #2825, #2838.

@bjfish
Copy link
Contributor Author

bjfish commented Apr 20, 2015

@eregon Yes, I ran all the tests like this jt test mri ruby/test_alias || jt test mri ruby/test_clone.rb || .... Then, I used this script to generate the test index and exclude files and directories from the test output: https://gist.github.com/bjfish/e6965cb3ae9226d83998

I hope to extract some of that logic later on to create a tag/untag tool for these tests.

@bjfish
Copy link
Contributor Author

bjfish commented Apr 20, 2015

@chrisseaton Also, this byteslice PR is need for the tests to complete successfully: https://github.com/jruby/jruby/pull/2848/files

@bjfish bjfish force-pushed the truffle_mri_index_excludes branch from 5999203 to 98be7e7 Compare April 20, 2015 14:20
@bjfish
Copy link
Contributor Author

bjfish commented Apr 20, 2015

@eregon fixed the excludes for test classes inside of modules here: #2849. So, I've uncommented all these modules tests in the test index to add them back

Finished tests in 36.891000s, 45.1872 tests/s, 3343.3900 assertions/s.

1667 tests, 123341 assertions, 0 failures, 0 errors, 11 skips

chrisseaton added a commit that referenced this pull request Apr 21, 2015
[Truffle] Adding initial MRI test index and excludes.
@chrisseaton chrisseaton merged commit 2c7e601 into jruby:master Apr 21, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 21, 2015
@bjfish bjfish deleted the truffle_mri_index_excludes branch April 21, 2015 13:00
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants