1411 #768
Closed
1411 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITs for FCREPO-1411
fcrepo-1411
| while (stmtIterator.hasNext()) { | ||
| final Statement s = stmtIterator.next(); | ||
| final Resource subject = s.getSubject(); | ||
| if (!subject.toString().contains(getPath())) { |
There was a problem hiding this comment.
This test is badly wrong.
- It is comparing a JCR value (the result of
getPath()) with an RDF value (subject.toString()). That kind of comparison must be mediated by anIdentifierConverter. Use something more likeequals(idTranslator.convert(subject)), catching exceptions, or pass in the request URI and do a comparison to that. - It does not account for blank nodes.
- It does not account for hash-URIs
| @@ -465,10 +467,23 @@ public Boolean isNew() { | |||
| public void replaceProperties(final IdentifierConverter<Resource, FedoraResource> idTranslator, | |||
| final Model inputModel, final RdfStream originalTriples) throws MalformedRdfException { | |||
|
|
|||
| LOGGER.info("Resource path: {}", getPath()); | |||
|
|
|||
| final StmtIterator stmtIterator = inputModel.listStatements(); | |||
There was a problem hiding this comment.
if you are going to use a loop here at all, use listSubjects() instead. It might be better to use Model.query(Selector s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Just for testing. Please ignore style issues.