Remove jquery #159
Remove jquery #159
Conversation
Removes the use of jquery to get the value of the dag path input box. Addresses part of #133
Removes the use of jquery to get the files hash from the elements attrs. Instead we will create a callback for the click that will handle each files unpin. Also cleaned up things a bit, more will be required. Addresses part of #133
Removed editable as it's not used anywhere in the code. Addresses part of #133
Removed the use of jquery to dynamically set the height of the config textarea. Addresses part of #133
Use regular old javascript to retrieve the value from the event and trim off the extra. Addresses part of #133
Removed the hover class addition/removal as it appeared not to be doing anything, also used good-ol JavaScript to perform click operation. Addresses part of #133
travisperson
force-pushed
the
remove-jquery
branch
from
8fc543f to
6f6a631
Compare
|
👏👏👏👏👏👏👏👏 Thank you @travisperson, this has been one of the main things that comes to discussion when talking about the WebUI |
| @@ -113,7 +111,7 @@ export default React.createClass({ | |||
| {error} | |||
| {buttons} | |||
| <div className='textarea-panel panel panel-default padded'> | |||
| <textarea className='panel-inner' spellCheck='false' onChange={this.handleChange} value={this.state.body} /> | |||
| <textarea ref='textareaConfig' className='panel-inner' style={{height: this.state.height}} spellCheck='false' onChange={this.handleChange} value={this.state.body} /> | |||
There was a problem hiding this comment.
Can you add line breaks here please, this line is getting a bit long
|
Thanks @travisperson for doing this, I left some nit picks inline |
|
Another note, when do not require jquery anymore we can drop it from the deps in |
| <a href='#' onClick={unpin}> | ||
| <OverlayTrigger placement='right' overlay={tooltip}> | ||
| {/* The block element is required otherwise the overlay is *over* the icon */} | ||
| <div style={{display: 'inline-block'}}><i className='fa fa-remove'></i></div> |
There was a problem hiding this comment.
You can use <Icon glyph='remove' />
refactor: Upgrade to react-router@2
feat: Replace console.log with debug
As noted by @diasdavid in #130 (comment)
| e.stopPropagation() | ||
| e.preventDefault() | ||
| }, | ||
|
|
||
| onDrop: function (e) { | ||
| this.setState({ dragging: false }) | ||
| $(e.target).removeClass('hover') |
There was a problem hiding this comment.
Won't removing hover affect the CSS?
There was a problem hiding this comment.
The only css the defining a hover class was for an element matching the following selector .file-add-container .file-add-container-inner which none of these effected. The hover class for that is handled on line 154 (old code) or 148 (new code).
I'm pretty sure it's just dead code.
|
LGTM, given the things above. 👍 |
Moved the FileItem to a seperate file. Switched to using Glyphicon instead of a div for block element.
Fixes and release of a new version for 0.3.11
webpack@1.12.11 breaks build⚠️
stream-http@2.1.0 breaks build⚠️
…0.3.7 karma-sourcemap-loader@0.3.7 breaks build⚠️
|
I've been waiting on comments from you for a few things. This is in the |
i18next@2.0.21 breaks build⚠️
i18next@2.0.22 breaks build⚠️
autoprefixer@6.3.0 breaks build⚠️
Update i18next-xhr-backend to version 0.3.0 🚀
…runtime-6.4.3 babel-plugin-transform-runtime@6.4.3 breaks build⚠️
autoprefixer@6.3.1 breaks build⚠️
|
Thanks @travisperson I finished it up for now so we can merge it :) |
This strips out all the jquery used throughout the webui.
Closes #133