diagnostic.Engine: rename print_diagnostic→render_diagnostic; always call it.

whitequark · whitequark · commit 8bdc7badbd08 · 2016-01-04T21:32:04.000+08:00
diff --git a/pythonparser/diagnostic.py b/pythonparser/diagnostic.py
@@ -151,11 +151,10 @@ def process(self, diagnostic):
         The default implementation of :meth:`process` renders non-fatal
         diagnostics to ``sys.stderr``, and raises fatal ones as a :class:`Error`.
         """
+        self.render_diagnostic(diagnostic)
         if diagnostic.level == "fatal" or \
                 (self.all_errors_are_fatal and diagnostic.level == "error"):
             raise Error(diagnostic)
-        else:
-            self.print_diagnostic(diagnostic)
 
-    def print_diagnostic(self, diagnostic):
+    def render_diagnostic(self, diagnostic):
         sys.stderr.write("\n".join(diagnostic.render()) + "\n")
diff --git a/pythonparser/test/test_lexer.py b/pythonparser/test/test_lexer.py
@@ -11,6 +11,7 @@ def assertLexesVersions(self, input, versions, *expected_tokens, **kwargs):
             tokens = expected_tokens
             self.buffer = source.Buffer(input)
             self.engine = diagnostic.Engine(all_errors_are_fatal=True)
+            self.engine.render_diagnostic = lambda diag: None
             self.lexer = lexer.Lexer(self.buffer, version, self.engine, **kwargs)
             for token in self.lexer:
                 if len(tokens) < 2:
diff --git a/pythonparser/test/test_parser.py b/pythonparser/test/test_parser.py
@@ -22,6 +22,7 @@ def parser_for(self, code, version, interactive=False):
 
         self.source_buffer = source.Buffer(code, str(version))
         self.engine = diagnostic.Engine()
+        self.engine.render_diagnostic = lambda diag: None
         self.lexer = lexer.Lexer(self.source_buffer, version, self.engine,
                                  interactive=interactive)
 
