fix(object) Ensure keys for all rendered array elements #166
+641
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
changed the title
dignifiedquire
force-pushed
the
fix/161
branch
from
99d0401 to
522c56d
Compare
| ObjectLinks.propTypes = { | ||
| path: PropTypes.instanceOf(Path).isRequired, | ||
| links: PropTypes.arrayOf(PropTypes.shape({ | ||
| Hash: PropTypes.string.isRequired, |
There was a problem hiding this comment.
that's what we get from the js-ipfs-api
dignifiedquire
force-pushed
the
fix/161
branch
from
e5a4a80 to
eb2dbe2
Compare
dignifiedquire
force-pushed
the
fix/161
branch
from
eb2dbe2 to
c798ea8
Compare
| @@ -1,5 +1,8 @@ | |||
| { | |||
| "presets": ["react", "es2015", "stage-0"], | |||
| "plugins": [ | |||
| 'transform-runtime' | |||
There was a problem hiding this comment.
Is this a node module? If not, where is it loaded from?
There was a problem hiding this comment.
This is a node module called babel-plugin-transform-runtime which is loaded by babel on its own, same with the presets.
|
Overall, looks good to me, from an overview of the code and not from an I-tried-to-run-this perspective. Happy to merge it. |
dignifiedquire
added a commit
that referenced
this pull request
Jan 6, 2016
fix(object) Ensure keys for all rendered array elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161
Missing: