-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel#autoload? returns true after the file has been required #3585
Comments
…appened (jrubyGH-3585) in this case the finishAutolog never gets called and thus autoload-map is not cleared!
…appened (GH-3585) in this case the finishAutolog never gets called and thus autoload-map is not cleared!
now working with 75ee995#diff-b0dc42ec523c3c3de1ac9ff40bc56852R213 - leaving open as in case of explicit |
* master: (35 commits) [Truffle] Remove redundant checks for the type in Array nodes. [Truffle] Consistently name Array nodes. [Truffle] Add a few layout guards in ShapeCachingGuards. [Truffle] Some refactoring in Hash#[]=. [Truffle] Use helpers in Hash#[] for eql?/equal? deprecate IAutoloadMethod in favor of interface at RubyModule cleanup imports remove dead method handle autoload? returning nil when an explicit require of the file happened (GH-3585) loop through module hierarchy when checking autoload? - now behaving as MRI's update getConstant lookup to avoid auto-loading constant on a const_defined? check avoid replaceAll regexp due load service '.so' library '.jar' substitution + null warnings cleanup & align const_defined? + const_get impl methods [test] import ruby/test_autoload.rb from MRI 2.2.4 make RubyKernel's autoload Ruby method receive a thread-context use isUTF8() where possible update to latest jcodings [Truffle] Off-by-one. [Truffle] Have a much simpler Array#fill for compilation. [Truffle] Make our Entry class final. ...
@kares Does MRI handle that case? |
Oh nevermind...that's what this bug originally reported. Yeah, weird. |
It looks like MRI does this through an additional check. After they lookup and find an autoload for the given constant, they go back to loaded features and see if the autoload file has been loaded in some form. |
so it sounds that we should additionally trigger a |
Not sure why we never re-tested this but it appear to be working fine in 9.3.
|
test.rb:
Different behaviour from MRI:
This is failing for Tilt: https://travis-ci.org/rtomayko/tilt/builds/101022917
The text was updated successfully, but these errors were encountered: