Skip to content

Commit

Permalink
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tool/jt.rb
Original file line number Diff line number Diff line change
@@ -160,7 +160,7 @@ def sh(*args)
end

def mvn(*args)
sh './mvnw', *args
sh './mvnw', *(['-q'] + args)
end

def mspec(command, *args)

7 comments on commit 29db9da

@chrisseaton
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pitr-ch @eregon @nirvdrum are people in favour of this?

@headius
Copy link
Member

@headius headius commented on 29db9da Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use -q 99% of the time for my maven builds. I even made an alias m='mvn -q' in my shell.

Only down side is that it silences important info you might need to fix a broken build, so I frequently have to go back to a full mvn for that. You wouldn't be able to do that through this change.

Sorry, something went wrong.

@eregon
Copy link
Member

@eregon eregon commented on 29db9da Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem is it does not show progress at all for building.
jt test tck looks nice though.
Could we have a version that is not -q for debugging the build or checking correct IDE setup ?

Sorry, something went wrong.

@pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented on 29db9da Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adding a --verbose option to turn it back on?

@nirvdrum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anything involving maven, I've just used mvn. I didn't know some of these commands even existed. So, I'm happy with whatever the rest of you decide.

@chrisseaton
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't use jt to build at all?

@nirvdrum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I tried once a while back and had trouble with it building reliably. I just use mvn package -DskipTests=true, which is aliased to mp in my shell.

Please sign in to comment.