simplistic implementation of data caching and persistance #2210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of data caching/persistence is intentionally simplistic. The parameters for the design were:
So, what do you think?
Known problems:
To make this atomic, it needs slightly more complicated saving code. Since doit can run threaded, that's important.In order not to miss saved data when using multiprocess mode, it may need to reload the file on each read / some reads, which makes it much more expensive.