Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/artiq
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4198601abb4d
Choose a base ref
...
head repository: m-labs/artiq
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bbd0ca782702
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jan 10, 2016

  1. Copy the full SHA
    b298170 View commit details
  2. Copy the full SHA
    c46fccd View commit details
  3. Commit missing parts of 9366a29.

    whitequark committed Jan 10, 2016
    Copy the full SHA
    bbd0ca7 View commit details
Showing with 10 additions and 2 deletions.
  1. +2 −1 artiq/compiler/transforms/artiq_ir_generator.py
  2. +6 −1 artiq/compiler/transforms/llvm_ir_generator.py
  3. +2 −0 artiq/runtime/session.c
3 changes: 2 additions & 1 deletion artiq/compiler/transforms/artiq_ir_generator.py
Original file line number Diff line number Diff line change
@@ -320,7 +320,8 @@ def visit_function(self, node, is_lambda, is_internal):
return self.append(ir.Closure(func, self.current_env))

def visit_FunctionDefT(self, node, in_class=None):
func = self.visit_function(node, is_lambda=False, is_internal=len(self.name) > 2)
func = self.visit_function(node, is_lambda=False,
is_internal=len(self.name) > 0 or '.' in node.name)
if in_class is None:
self._set_local(node.name, func)
else:
7 changes: 6 additions & 1 deletion artiq/compiler/transforms/llvm_ir_generator.py
Original file line number Diff line number Diff line change
@@ -176,6 +176,7 @@ def __init__(self, engine, module_name, target, object_map, type_map):
self.llobject_map = {}
self.phis = []
self.debug_info_emitter = DebugInfoEmitter(self.llmodule)
self.empty_metadata = self.llmodule.add_metadata([])

def needs_sret(self, lltyp, may_be_large=True):
if isinstance(lltyp, ll.VoidType):
@@ -628,6 +629,7 @@ def llptr_to_var(self, llenv, env_ty, var_name, var_type=None):
outer_index = list(env_ty.params.keys()).index("$outer")
llptr = self.llbuilder.gep(llenv, [self.llindex(0), self.llindex(outer_index)])
llouterenv = self.llbuilder.load(llptr)
llouterenv.metadata['invariant.load'] = self.empty_metadata
return self.llptr_to_var(llouterenv, env_ty.params["$outer"], var_name)

def process_GetLocal(self, insn):
@@ -638,7 +640,9 @@ def process_GetLocal(self, insn):
def process_GetConstructor(self, insn):
env = insn.environment()
llptr = self.llptr_to_var(self.map(env), env.type, insn.var_name, insn.type)
return self.llbuilder.load(llptr)
llconstr = self.llbuilder.load(llptr)
llconstr.metadata['invariant.load'] = self.empty_metadata
return llconstr

def process_SetLocal(self, insn):
env = insn.environment()
@@ -874,6 +878,7 @@ def get_outer(llenv, env_ty):
outer_index = list(env_ty.params.keys()).index("$outer")
llptr = self.llbuilder.gep(llenv, [self.llindex(0), self.llindex(outer_index)])
llouterenv = self.llbuilder.load(llptr)
llouterenv.metadata['invariant.load'] = self.empty_metadata
return self.llptr_to_var(llouterenv, env_ty.params["$outer"], var_name)
else:
return llenv
2 changes: 2 additions & 0 deletions artiq/runtime/session.c
Original file line number Diff line number Diff line change
@@ -1012,6 +1012,7 @@ static int process_kmsg(struct msg_base *umsg)
}

mailbox_send(&reply);
break;
}

case MESSAGE_TYPE_CACHE_PUT_REQUEST: {
@@ -1049,6 +1050,7 @@ static int process_kmsg(struct msg_base *umsg)
}

mailbox_send(&reply);
break;
}

default: {