-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2867] modified Date#>> to take calendar reforms under consideration #3091
Conversation
ranslogs
commented
Jun 29, 2015
- added tests for next month with calendar reform
- uses solution provided in Inconsistency with MRI when adding a month to a date near Date::ITALY #1769 comments
- also fixes issues Inconsistency with MRI when adding a month to a date near Date::ITALY #1769
…ation - added tests for next month with calendar reform - uses solution provided in jruby#1769 comments - also fixes issues jruby#1769
@raeoks would you mind trying to target jruby-1_7 so that this is fixed in JRuby 1.7.x as well? @eregon since its mostly your work-around ... any thoughts on getting those in? |
These tests would be useful in RubySpec. You can just do a separate commit touching Well, if this behavior must be supported, I'd say there is not much choice. |
I'll move test cases from |
The changes look ok to me but I defer to @eregon on when and whether this should merge. |
@raeoks Could you move the test cases to specs? Or should I do it? |
@eregon I'll do it and doing it right now. |
I guess yes but better ask @kares. |
optimally, there would be only one PR targeting jruby-1_7 (branch is periodically merged to master) ... |