Minor code cleanup #824
Closed
Minor code cleanup #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajs6f
force-pushed
the
HttpCommonsPreJava8Stuff
branch
from
eb45cbb
to
0e52cc6
Compare
| } | ||
| }; | ||
|
|
||
| private static final HttpHeaderReader.ListElementCreator<PreferTag> PREFER_CREATOR = r -> new PreferTag(r); |
There was a problem hiding this comment.
This would also work, no?
PREFER_CREATOR = PreferTag::new;
There was a problem hiding this comment.
Nice, yes. Maybe just in-line it?
| * @param second | ||
| * @throws Exception | ||
| */ | ||
| void acceptThrows(final S first, final T second) throws Exception; |
There was a problem hiding this comment.
This is an interface. There are no private methods.
|
Resolved with: e8b3f63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/FCREPO-1603