-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] BigDecimal #3084
[Truffle] BigDecimal #3084
Conversation
'-' | ||
when self == 0 | ||
'' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation looks a bit strange to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean case/when or aligned = ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the =
is the clearest here.
Not sure for case
/when
but it might make sense to avoid anything that has visually so many levels of indentation (so when
would have the same indent as the line before).
658a425
to
07111e7
Compare
"isSpecialRubyBigDecimal(b)" }) | ||
public Object divNormalSpecial(VirtualFrame frame, RubyBasicObject a, RubyBasicObject b, NotProvided precision) { | ||
if (getBigDecimalType(b) == Type.NEGATIVE_ZERO) { | ||
throw new RaiseException(getContext().getCoreLibrary().zeroDivisionError(this)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should transfer before you throw here.
Sorry about the missing transfers ( I've forgot again 😠 ). Added. |
Please wait with merge, 1 or 2 commits and BigDecimal is done. |
Ready for merge. |
Looks good! |
com.oracle.truffle.api.dsl.UnsupportedSpecializationException
…supportedOperationException
…all types * move creation from string to CreateBigDecimalNode
No description provided.