[Truffle] BigDecimal #3084
Merged
[Truffle] BigDecimal #3084
+577
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '-' | ||
| when self == 0 | ||
| '' | ||
| end |
There was a problem hiding this comment.
The indentation looks a bit strange to me.
There was a problem hiding this comment.
Do you mean case/when or aligned = ?
There was a problem hiding this comment.
the = is the clearest here.
Not sure for case/when but it might make sense to avoid anything that has visually so many levels of indentation (so when would have the same indent as the line before).
pitr-ch
force-pushed
the
bigdecimal
branch
2 times, most recently
from
658a425 to
07111e7
Compare
| "isSpecialRubyBigDecimal(b)" }) | ||
| public Object divNormalSpecial(VirtualFrame frame, RubyBasicObject a, RubyBasicObject b, NotProvided precision) { | ||
| if (getBigDecimalType(b) == Type.NEGATIVE_ZERO) { | ||
| throw new RaiseException(getContext().getCoreLibrary().zeroDivisionError(this)); |
There was a problem hiding this comment.
You should transfer before you throw here.
|
Sorry about the missing transfers ( I've forgot again 😠 ). Added. |
|
Please wait with merge, 1 or 2 commits and BigDecimal is done. |
|
Ready for merge. |
|
Looks good! |
com.oracle.truffle.api.dsl.UnsupportedSpecializationException
…supportedOperationException
…all types * move creation from string to CreateBigDecimalNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.