Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate id mapper #27

Closed
wants to merge 4 commits into from

Conversation

mikedurbin
Copy link
Contributor

@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be named logback-test.xml.

temp.delete();
temp.mkdir();
indexDir = new File(temp, "index");
LOGGER.info("No generated ID index directory specified. Creating temporary index at \""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but you should probably be using the more efficient slf4j logging syntax:
mporary index at \"{}\".", indexDir.getAbsolutePath());

@awoods
Copy link

awoods commented Jun 30, 2015

Resolved with:
896b2cb and
b98cfab

@awoods awoods closed this Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants